Make sh scrips POSIX compliant

Using shellcheck, I went through all of them to make them standards
compliant. I also tested as many as I could.

1 files changed, 6 insertions, 9 deletions

diff --git a/mbc b/mbc
index 292c3e3..56fc92b 100755
--- a/mbc
+++ b/mbc
@@ -3,15 +3,15 @@
 #{{{ printhelp
 printhelp () {
   printf "mbc: mullvad-browser menu interface.\n"
-  printf "  -u URL  ) pass URL to browser\n"
-  printf "  -d ARGS ) pass ARGS to menu command\n"
+  printf "  -u URL ) pass URL to browser\n"
+  printf "  -d ARG ) pass ARG to menu command\n"
   exit
 }
 #}}}
 
 #{{{ getopts
 while getopts "hd:u:" o; do case "${o}" in
-  d) DMENU_ARGS="$OPTARG" ;;
+  d) ARG="$OPTARG" ;;
   u) URL="$OPTARG" ;;
   *) printhelp ;;
 esac done
@@ -19,21 +19,18 @@ esac done
 
 #{{{ Native Profiles
 if [ -f ~/.mullvad/mullvadbrowser/profiles.ini ]; then
-  NATIVE_PROFILES=`grep 'Path=' ~/.mullvad/mullvadbrowser/profiles.ini | cut -d'.' -f2`
+  NATIVE_PROFILES=$(grep 'Path=' ~/.mullvad/mullvadbrowser/profiles.ini | cut -d'.' -f2)
 else
   unset NATIVE_PROFILES
 fi
 #}}}
 
 #{{{ Add Profiles
-if [ -n "$NATIVE_PROFILES" ]; then
-  INT="\n"
-fi
 PROFILES="$NATIVE_PROFILES"
 #}}}
 
 #{{{ Choose Profiles
-CHOSEN=`printf "$PROFILES" | dmenu -l 15 -p "mullvad-browser" $DMENU_ARGS`
+CHOSEN=$(printf "%s" "$PROFILES" | dmenu -l 15 -p "mullvad-browser" ${ARG:+"$ARG"})
 [ -z "$CHOSEN" ] && exit 2
-exec mullvad-browser -P "$CHOSEN" $URL
+exec mullvad-browser -P "$CHOSEN" "$URL"
 #}}}