From f28d694879239d5d9c319185a278236d317a49b6 Mon Sep 17 00:00:00 2001 From: zachir Date: Sat, 30 Aug 2025 01:09:18 -0500 Subject: Make sh scrips POSIX compliant Using shellcheck, I went through all of them to make them standards compliant. I also tested as many as I could. --- qbc | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) (limited to 'qbc') diff --git a/qbc b/qbc index b0dad2e..dfe688d 100755 --- a/qbc +++ b/qbc @@ -3,36 +3,36 @@ #{{{ printhelp printhelp () { printf "qbc: qutebrowser menu interface.\n" - printf " -u URL ) pass URL to browser\n" - printf " -d ARGS ) pass ARGS to menu command\n" + printf " -u URL ) pass URL to browser\n" + printf " -d ARG ) pass ARGS to menu command\n" exit } #}}} #{{{ getopts while getopts "hd:u:" o; do case "${o}" in - d) DMENU_ARGS="$OPTARG" ;; + d) ARG="$OPTARG" ;; u) URL="$OPTARG" ;; *) printhelp ;; esac done #}}} #{{{ Get Sessions -SESSIONS=`qbpm list` -[ -z "$SESSIONS" ] && qutebrowser $@ && exit +SESSIONS=$(qbpm list) +[ -z "$SESSIONS" ] && qutebrowser "$@" && exit #}}} #{{{ Select Session -CHOSEN=`printf "default\n$SESSIONS" | dmenu -l 15 -p "qutebrowser" $DMENU_ARGS` +CHOSEN=$(printf "default\n%s" "$SESSIONS" | dmenu -l 15 -p "qutebrowser" ${ARG:+"$ARG"}) [ -z "$CHOSEN" ] && exit 2 if [ -n "$CHOSEN" ]; then if [ "$CHOSEN" = "default" ]; then - qutebrowser $URL + qutebrowser "$URL" else - if [ -z `echo "$SESSIONS" | grep "$CHOSEN"` ]; then + if echo "$SESSIONS" | { ! grep -q "$CHOSEN" ; }; then qbpm new "$CHOSEN" fi - qbpm launch "$CHOSEN" $URL + qbpm launch "$CHOSEN" "$URL" #qutebrowser -B "$HOME/.local/share/$CHOSEN" fi fi -- cgit v1.2.3