From f28d694879239d5d9c319185a278236d317a49b6 Mon Sep 17 00:00:00 2001
From: zachir <zachir@librem.one>
Date: Sat, 30 Aug 2025 01:09:18 -0500
Subject: Make sh scrips POSIX compliant

Using shellcheck, I went through all of them to make them standards
compliant. I also tested as many as I could.
---
 mprisctl | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

(limited to 'mprisctl')

diff --git a/mprisctl b/mprisctl
index b784523..0d71b94 100755
--- a/mprisctl
+++ b/mprisctl
@@ -5,11 +5,11 @@ printhelp () {
 }
 
 while getopts "hd:" o; do case "${o}" in
-  d) ARGS="$ARGS$OPTARG " ;;
+  d) ARG="$OPTARG" ;;
   *) printhelp ;;
 esac done
 
-DMENU_PROMPT=$(playerctl -l | dmenu $ARGS -p 'Players:')
+DMENU_PROMPT=$(playerctl -l | dmenu ${ARG:+"$ARG"} -p 'Players:')
 [ -z "$DMENU_PROMPT" ] && exit 1
 
 PLAYERCONTROLS_PROMPT=$(echo "play-pause
@@ -21,7 +21,7 @@ previous
 position
 volume
 status
-shuffle" | dmenu $ARGS -p 'Action:')
+shuffle" | dmenu ${ARG:+"$ARG"} -p 'Action:')
 [ -z "$PLAYERCONTROLS_PROMPT" ] && exit 1
 
 case "$PLAYERCONTROLS_PROMPT" in
@@ -29,12 +29,12 @@ case "$PLAYERCONTROLS_PROMPT" in
     playerctl -p "$DMENU_PROMPT" "$PLAYERCONTROLS_PROMPT"
     ;;
   "position")
-    VALUE=$(seq -100 5 +100 | grep -v '^0$' | sed 's/^[0-9]/\+&/' | dmenu $ARGS -p 'Position:')
+    VALUE=$(seq -100 5 +100 | grep -v '^0$' | sed 's/^[0-9]/\+&/' | dmenu ${ARG:+"$ARG"} -p 'Position:')
     [ -z "$VALUE" ] && exit 1
     playerctl -p "$DMENU_PROMPT" "$PLAYERCONTROLS_PROMPT" "$VALUE"
     ;;
   "volume")
-    VALUE=$(set 0 5 100 |dmenu $ARGS -p 'Volume:')
+    VALUE=$(set 0 5 100 |dmenu ${ARG:+"$ARG"} -p 'Volume:')
     [ -z "$VALUE" ] && exit 1
     playerctl -p "$DMENU_PROMPT" "$PLAYERCONTROLS_PROMPT" "$VALUE"
     ;;
@@ -46,7 +46,7 @@ case "$PLAYERCONTROLS_PROMPT" in
     VALUE=$(echo "On
 Off
 Toggle
-Status" | dmenu $ARGS -p "Shuffle:")
+Status" | dmenu ${ARG:+"$ARG"} -p "Shuffle:")
     [ -z "$VALUE" ] && exit 1
     case "$VALUE" in
       "On"|"Off"|"Toggle")
-- 
cgit v1.2.3