From f28d694879239d5d9c319185a278236d317a49b6 Mon Sep 17 00:00:00 2001 From: zachir Date: Sat, 30 Aug 2025 01:09:18 -0500 Subject: Make sh scrips POSIX compliant Using shellcheck, I went through all of them to make them standards compliant. I also tested as many as I could. --- ffc | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) (limited to 'ffc') diff --git a/ffc b/ffc index b40ec75..4fcbdd4 100755 --- a/ffc +++ b/ffc @@ -3,15 +3,15 @@ #{{{ printhelp printhelp () { printf "ffc: firefox menu interface.\n" - printf " -u URL ) pass URL to browser\n" - printf " -d ARGS ) pass ARGS to menu command\n" + printf " -u URL ) pass URL to browser\n" + printf " -d ARG ) pass ARG to menu command\n" exit } #}}} #{{{ getopts while getopts "hd:u:" o; do case "${o}" in - d) DMENU_ARGS="$OPTARG" ;; + d) ARG="$OPTARG" ;; u) URL="$OPTARG" ;; *) printhelp ;; esac done @@ -19,7 +19,7 @@ esac done #{{{ Native Profiles if [ -f ~/.mozilla/firefox/profiles.ini ]; then - NATIVE_PROFILES=`grep 'Path=' ~/.mozilla/firefox/profiles.ini | cut -d'.' -f2` + NATIVE_PROFILES=$(grep 'Path=' ~/.mozilla/firefox/profiles.ini | cut -d'.' -f2) else unset NATIVE_PROFILES fi @@ -27,25 +27,25 @@ fi #{{{ Flatpak Profiles if [ -f ~/.var/app/org.mozilla.firefox/.mozilla/firefox/profiles.ini ]; then - FLATPAK_PROFILES=`grep 'Path=' ~/.var/app/org.mozilla.firefox/.mozilla/firefox/profiles.ini | cut -d'.' -f2 | sed 's/$/ F/g'` + FLATPAK_PROFILES=$(grep 'Path=' ~/.var/app/org.mozilla.firefox/.mozilla/firefox/profiles.ini | cut -d'.' -f2 | sed 's/$/ F/g') else unset FLATPAK_PROFILES fi #}}} #{{{ Add Profiles -if [ -n "$NATIVE_PROFILES" -a -n "$FLATPAK_PROFILES" ]; then +if [ -n "$NATIVE_PROFILES" ] && [ -n "$FLATPAK_PROFILES" ]; then INT="\n" fi PROFILES="$NATIVE_PROFILES$INT$FLATPAK_PROFILES" #}}} #{{{ Choose Profiles -CHOSEN=`printf "$PROFILES" | dmenu -l 15 -p "firefox" $DMENU_ARGS` +CHOSEN=$(printf "%s" "$PROFILES" | dmenu -l 15 -p "firefox" ${ARG:+"$ARG"}) [ -z "$CHOSEN" ] && exit 2 -if `echo "$CHOSEN" | grep -qE ' F$'`; then - exec flatpak run org.mozilla.Firefox -P `echo "$CHOSEN" | sed 's/ F$//'` $URL +if echo "$CHOSEN" | grep -qE ' F$'; then + exec flatpak run org.mozilla.Firefox -P "$(echo "$CHOSEN" | sed 's/ F$//')" "$URL" else - exec firefox -P "$CHOSEN" $URL + exec firefox -P "$CHOSEN" "$URL" fi #}}} -- cgit v1.2.3