From f28d694879239d5d9c319185a278236d317a49b6 Mon Sep 17 00:00:00 2001 From: zachir Date: Sat, 30 Aug 2025 01:09:18 -0500 Subject: Make sh scrips POSIX compliant Using shellcheck, I went through all of them to make them standards compliant. I also tested as many as I could. --- brc | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) (limited to 'brc') diff --git a/brc b/brc index 4a7dcc9..c4230bf 100755 --- a/brc +++ b/brc @@ -2,16 +2,16 @@ #{{{ printhelp printhelp () { - printf "lwc: librewolf menu interface.\n" - printf " -u URL ) pass URL to browser\n" - printf " -d ARGS ) pass ARGS to menu command\n" + printf "brc: brave profile menu interface.\n" + printf " -u URL ) pass URL to browser\n" + printf " -d ARG ) pass ARG to menu command\n" exit } #}}} #{{{ getopts while getopts "hd:u:" o; do case "${o}" in - d) DMENU_ARGS="$OPTARG" ;; + d) ARG="$OPTARG" ;; u) URL="$OPTARG" ;; *) printhelp ;; esac done @@ -19,21 +19,14 @@ esac done #{{{ Native Profiles if [ -d ~/.local/share/brave_profiles ]; then - NATIVE_PROFILES=`ls -1 ~/.local/share/brave_profiles` + PROFILES=$(ls -1 ~/.local/share/brave_profiles) else - unset NATIVE_PROFILES + unset PROFILES fi #}}} -#{{{ Add Profiles -if [ -n "$NATIVE_PROFILES" -a -n "$FLATPAK_PROFILES" ]; then - INT="\n" -fi -PROFILES="$NATIVE_PROFILES$INT$FLATPAK_PROFILES" -#}}} - #{{{ Choose Profiles -CHOSEN=`printf "$PROFILES" | dmenu -l 15 -p brave $DMENU_ARGS` +CHOSEN=$(printf "%s" "$PROFILES" | dmenu -l 15 -p brave ${ARG:+"$ARG"}) [ -z "$CHOSEN" ] && exit 2 brave-profiles "$CHOSEN" "$URL" #}}} -- cgit v1.2.3